collin/autobaan
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rearranging waiting for network idle to prevent race when there are 2 reservations

Browse source
This commit is contained in:
Collin Duncan 2023-09-21 09:28:22 +02:00
parent 5875ad2050
commit 2e1401644d
No known key found for this signature in database
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/runner/baanreserveren/service.ts
View file

@ -129,6 +129,7 @@ export class BaanReserverenService {
reservation: instanceToPlain(reservation), reservation: instanceToPlain(reservation),
}) })
await this.page.goto(BAAN_RESERVEREN_ROOT_URL) await this.page.goto(BAAN_RESERVEREN_ROOT_URL)
await this.page.waitForNetworkIdle()
const action = await this.checkSession(reservation.username) const action = await this.checkSession(reservation.username)
switch (action) { switch (action) {
case SessionAction.Logout: case SessionAction.Logout:
@ -271,7 +272,6 @@ export class BaanReserverenService {
private async openWaitingListDialog() { private async openWaitingListDialog() {
this.loggerService.debug('Opening waiting list dialog') this.loggerService.debug('Opening waiting list dialog')
await this.page.waitForNetworkIdle()
await this.page.goto( await this.page.goto(
`${BAAN_RESERVEREN_ROOT_URL}/${BaanReserverenUrls.WaitingListAdd}`, `${BAAN_RESERVEREN_ROOT_URL}/${BaanReserverenUrls.WaitingListAdd}`,
) )
@ -343,6 +343,7 @@ export class BaanReserverenService {
.catch((e: Error) => { .catch((e: Error) => {
throw new RunnerReservationConfirmSubmitError(e) throw new RunnerReservationConfirmSubmitError(e)
}) })
await this.page.waitForNetworkIdle()
} }
private async inputWaitingListDetails(reservation: Reservation) { private async inputWaitingListDetails(reservation: Reservation) {