From 7307cad3503f2bfbcc7b2112385df1490726eead Mon Sep 17 00:00:00 2001
From: collin <github@collinduncan.com>
Date: Tue, 28 Apr 2026 14:42:50 +0200
Subject: [PATCH] Modifying cleanUpExpiredReservations code to actually delete
 expired stuff

---
 src/reservations/cron.ts    |  4 +++-
 src/reservations/service.ts | 11 +++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/reservations/cron.ts b/src/reservations/cron.ts
index dbbb57e..aefded8 100644
--- a/src/reservations/cron.ts
+++ b/src/reservations/cron.ts
@@ -97,7 +97,9 @@ export class ReservationsCronService {
 		await this.ntfyProvider.sendCronStartNotification(
 			'cleanUpExpiredReservations',
 		)
-		const reservations = await this.reservationService.getByDate()
+		const reservations = await this.reservationService.getOlderThanDate(
+			dayjs().subtract(7, 'day'),
+		)
 		this.loggerService.debug(
 			`Found ${reservations.length} reservations to delete`,
 		)
diff --git a/src/reservations/service.ts b/src/reservations/service.ts
index 4d4a3e1..2e68024 100644
--- a/src/reservations/service.ts
+++ b/src/reservations/service.ts
@@ -41,6 +41,17 @@ export class ReservationsService {
 		return await qb.orderBy('dateRangeStart', 'ASC').getMany()
 	}
 
+	async getOlderThanDate(date = dayjs()) {
+		const query = this.reservationsRepository
+			.createQueryBuilder()
+			.where(`(DATE(dateRangeStart) < DATE(:startDate)`, {
+				startDate: date.toISOString(),
+			})
+			.orderBy('dateRangeStart', 'ASC')
+
+		return await query.getMany()
+	}
+
 	/**
 	 * Gets all reservations that have not been scheduled that are within the reservation window
 	 * @returns Reservations that can be scheduled